Revert "x86/HVM: also dump stacks from show_execution_state()"
authorRoger Pau Monne <roger.pau@citrix.com>
Fri, 4 Nov 2022 14:43:37 +0000 (15:43 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 9 Nov 2022 20:07:45 +0000 (20:07 +0000)
commit8febf78f1ed075292b664bf8c60c5f472028f955
tree163b1c87bd68fe3030a36675bf45ee0bdc1e784b
parentaa1bf3858551b7cd1facfb116fe35830aceac497
Revert "x86/HVM: also dump stacks from show_execution_state()"

This reverts commit adb715db698bc8ec3b88c24eb88b21e9da5b6c07.

The dumping of stacks for HVM guests is problematic, since it requires
taking the p2m lock in order to walk the guest page tables and the p2m.

The suggested solution to the issue is to introduce and use a lockless p2m
walker, that relies on being executed with interrupts disabled in order to
prevent any p2m pages from being freed while doing the walk.

Note that modifications of p2m entries are already done atomically in order
to prevent the hardware walker from seeing partially updated values.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
xen/arch/x86/traps.c